Issue 987313003: CrashReportDatabase: use InitializationStateDcheck to guard against API abuses and misuses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 987313003: CrashReportDatabase: use InitializationStateDcheck to guard against API abuses and misuses (Closed)

Created:
5 years, 9 months ago by Mark Mentovai

Modified:
5 years, 9 months ago

Reviewers:
Robert Sesek, scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

CrashReportDatabase: use InitializationStateDcheck to guard against API abuses and misuses. TEST=crashpad_client_test CrashReportDatabaseTest.* R=rsesek@chromium.org, scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/7979d9db4e097cbed41daae9857a44d382c1e217

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -3 lines)			Patch
	M	client/crash_report_database_mac.mm	View		10 chunks	+30 lines, -2 lines	0 comments	Download
	M	client/crash_report_database_win.cc	View		12 chunks	+26 lines, -1 line	0 comments	Download

Total messages: 6 (1 generated)

Robert Sesek

LGTM, though this one seems less necessary since it can only be created through ::Create().

5 years, 9 months ago (2015-03-10 16:26:55 UTC) #3

Mark Mentovai

It still provides a good use-after-free check when the memory hasn’t been reclaimed.

5 years, 9 months ago (2015-03-10 16:34:10 UTC) #4

Mark Mentovai

5 years, 9 months ago (2015-03-10 17:24:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7979d9db4e097cbed41daae9857a44d382c1e217 (presubmit successful).