Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 987303003: Revert of Fix old space check in IsSlotInBlackObject. (Closed)

Created:
5 years, 9 months ago by Hannes Payer (out of office)
Modified:
5 years, 9 months ago
Reviewers:
ulan, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Fix old space check in IsSlotInBlackObject. (patchset #1 id:1 of https://codereview.chromium.org/993513009/) Reason for revert: Breaks arm.debug. Original issue's description: > Fix old space check in IsSlotInBlackObject. > > BUG= > > Committed: https://crrev.com/4f865389bcecdff6aa56512fab3a147507a95a51 > Cr-Commit-Position: refs/heads/master@{#27090} TBR=ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d484d5bc4986cdf738405f990f5c5e645e65ce95 Cr-Commit-Position: refs/heads/master@{#27095}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/heap/mark-compact.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Hannes Payer (out of office)
Created Revert of Fix old space check in IsSlotInBlackObject.
5 years, 9 months ago (2015-03-10 11:54:32 UTC) #1
Yang
On 2015/03/10 11:54:32, Hannes Payer wrote: > Created Revert of Fix old space check in ...
5 years, 9 months ago (2015-03-10 11:55:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987303003/1
5 years, 9 months ago (2015-03-10 11:55:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 11:56:02 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 11:56:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d484d5bc4986cdf738405f990f5c5e645e65ce95
Cr-Commit-Position: refs/heads/master@{#27095}

Powered by Google App Engine
This is Rietveld 408576698