Issue 98723009: Change isBlock and isInline functions to check for isElementNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98723009: Change isBlock and isInline functions to check for isElementNode (Closed)

Created:
7 years ago by vanihegde

Modified:
6 years, 10 months ago

Reviewers:
leviw_travelin_and_unemployed, yosin_UTC9, ojan

CC:
blink-reviews, vanivhegde

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Change isBlock and isInline functions to check for isElementNode Simple refactoring to add isElementNode check in isBlock and isInline functions. Also removed isElementNode check from enclosingBlock. Webkit bug pointing the same - https://bugs.webkit.org/show_bug.cgi?id=86106 TEST=Refactoring, no behavior change. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163285

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	Source/core/editing/htmlediting.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vani.hegde@samsung.com/98723009/1

7 years ago (2013-12-05 18:40:14 UTC) #3

philipj_slow

6 years, 10 months ago (2014-02-07 17:07:39 UTC) #5

Message was sent while issue was closed.

It appears that this introduced a crash, see
https://code.google.com/p/chromium/issues/detail?id=341783