Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 987193003: Android: Fix GPU.GPUProcessTerminationStatus UMA stat (Closed)

Created:
5 years, 9 months ago by no sievers
Modified:
5 years, 9 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Android: Fix GPU.GPUProcessTerminationStatus UMA stat ChildProcessConnectionImpl.mAlwaysInForeground is used for the GPU process and indicates that it does not participate in hiding like renderers. The 'important' binding gives it the same priority as the main application, so upon termination we should just use the app's foreground status to determine whether the GPU process was in the foreground or not. BUG=462422 Committed: https://crrev.com/479947d99fd817737f517c068a77d74cd08183f8 Cr-Commit-Position: refs/heads/master@{#319768}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java View 1 2 chunks +11 lines, -3 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java View 1 2 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
no sievers
Ted, patl. A quick fix for the UMA reporting (to correctly differentiate in between crashed ...
5 years, 9 months ago (2015-03-09 22:31:51 UTC) #2
Ted C
lgtm https://codereview.chromium.org/987193003/diff/20001/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java File content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java (right): https://codereview.chromium.org/987193003/diff/20001/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java#newcode432 content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:432: private static boolean sApplicationInForeground = true; move this ...
5 years, 9 months ago (2015-03-09 22:35:03 UTC) #3
no sievers
https://codereview.chromium.org/987193003/diff/20001/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java File content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java (right): https://codereview.chromium.org/987193003/diff/20001/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java#newcode432 content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java:432: private static boolean sApplicationInForeground = true; On 2015/03/09 22:35:03, ...
5 years, 9 months ago (2015-03-09 22:38:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987193003/40001
5 years, 9 months ago (2015-03-09 22:39:47 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-09 23:29:48 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:31:12 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/479947d99fd817737f517c068a77d74cd08183f8
Cr-Commit-Position: refs/heads/master@{#319768}

Powered by Google App Engine
This is Rietveld 408576698