Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 987133003: Revert "Async DNS: Remove toggle from about:flags" (Closed)

Created:
3 years, 11 months ago by Deprecated (see juliatuttle)
Modified:
3 years, 11 months ago
Reviewers:
*davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Async DNS: Remove toggle from about:flags" This reverts commit eabf1f5baba38d46921acd6edda594f942f7d6a1. Removing the toggle in about:flags breaks a workaround for users who have nonstandard nsswitch configurations for hosts. Revert the removal until we properly check nsswitch.conf before assuming a standard configuration. BUG=117655 Committed: https://crrev.com/5f379e0e00068336aec9b4b78a49826b424152da Cr-Commit-Position: refs/heads/master@{#319725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Deprecated (see juliatuttle)
PTAL, davidben.
3 years, 11 months ago (2015-03-09 18:23:16 UTC) #3
davidben
lgtm
3 years, 11 months ago (2015-03-09 18:29:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987133003/1
3 years, 11 months ago (2015-03-09 18:49:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2015-03-09 20:45:33 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2015-03-09 20:49:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f379e0e00068336aec9b4b78a49826b424152da
Cr-Commit-Position: refs/heads/master@{#319725}

Powered by Google App Engine
This is Rietveld 408576698