Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 987123002: Advertise HTTP/2 support. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Advertise HTTP/2 support. Advertise "h2" token with ALPN and accept "h2" token in NPN. This is the final, almost-published version of HTTP/2. Add "h2" to relevant tests. Also add placeholder values (in comment) for drafts 16 and 17. They might be used for testing, or for collecting statistics about servers in the wild (not to be released on Stable channel though). BUG=401166 Committed: https://crrev.com/bfa20e6cbe5fcd30909b3e271005a527526385d9 Cr-Commit-Position: refs/heads/master@{#319767}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -31 lines) Patch
M chrome/browser/io_thread_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M components/domain_reliability/util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/http/http_response_info.h View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_info.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M net/http/http_server_properties.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_server_properties.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M net/http/http_stream_factory_impl_request_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/next_proto.h View 1 chunk +5 lines, -2 lines 0 comments Download
M net/socket/next_proto.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 4 chunks +9 lines, -4 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_pool_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 9 months ago (2015-03-09 19:11:25 UTC) #2
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-09 19:42:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987123002/1
5 years, 9 months ago (2015-03-09 21:06:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/48389)
5 years, 9 months ago (2015-03-09 22:33:28 UTC) #9
Bence
ttuttle: PTAL at components/domain_reliability/util.cc. Thank you.
5 years, 9 months ago (2015-03-09 23:12:53 UTC) #11
Deprecated (see juliatuttle)
On 2015/03/09 23:12:53, Bence wrote: > ttuttle: PTAL at components/domain_reliability/util.cc. Thank you. components/domain_reliability/util.cc lgtm. (I ...
5 years, 9 months ago (2015-03-09 23:17:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987123002/1
5 years, 9 months ago (2015-03-09 23:19:13 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 23:29:28 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 23:29:58 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bfa20e6cbe5fcd30909b3e271005a527526385d9
Cr-Commit-Position: refs/heads/master@{#319767}

Powered by Google App Engine
This is Rietveld 408576698