Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 987043004: Relanding "Reset the root layer on the compositor when recreating a root layer." (Closed)

Created:
5 years, 9 months ago by bruthig
Modified:
5 years, 9 months ago
Reviewers:
sadrul
CC:
chromium-reviews, Ian Vollick, sievers+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relanding "Reset the root layer on the compositor when recreating a root layer." Initial attempt found here: https://codereview.chromium.org/983933002/ This is going to be used by https://codereview.chromium.org/975943002/ TEST=LayerOwnerTest.RecreateRootLayerWithNullCompositor TEST=LayerOwnerTestWithCompositor.RecreateRootLayerWithCompositor BUG=337596 Committed: https://crrev.com/0df296f41a987c04a2aad2d19e9d5095c3a525c2 Cr-Commit-Position: refs/heads/master@{#319665}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed LayerOwnerTestWithCompositor::compositor_'s access from protected to private. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M ui/compositor/layer_owner.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/compositor/layer_owner_unittest.cc View 1 2 chunks +72 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bruthig
sadrul@ can you please have a look? I tried to land this fix on Friday ...
5 years, 9 months ago (2015-03-09 15:21:28 UTC) #2
sadrul
lgtm https://codereview.chromium.org/987043004/diff/1/ui/compositor/layer_owner_unittest.cc File ui/compositor/layer_owner_unittest.cc (right): https://codereview.chromium.org/987043004/diff/1/ui/compositor/layer_owner_unittest.cc#newcode29 ui/compositor/layer_owner_unittest.cc:29: scoped_ptr<ui::Compositor> compositor_; Make this private and add a ...
5 years, 9 months ago (2015-03-09 15:31:25 UTC) #3
bruthig
I updated the compositor_'s access. No need to review. https://codereview.chromium.org/987043004/diff/1/ui/compositor/layer_owner_unittest.cc File ui/compositor/layer_owner_unittest.cc (right): https://codereview.chromium.org/987043004/diff/1/ui/compositor/layer_owner_unittest.cc#newcode29 ui/compositor/layer_owner_unittest.cc:29: ...
5 years, 9 months ago (2015-03-09 15:59:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987043004/20001
5 years, 9 months ago (2015-03-09 15:59:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 17:19:55 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 17:20:29 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0df296f41a987c04a2aad2d19e9d5095c3a525c2
Cr-Commit-Position: refs/heads/master@{#319665}

Powered by Google App Engine
This is Rietveld 408576698