Issue 987033002: Roll WebRTC 8649:8651, Libjingle 8639:8651

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 987033002: Roll WebRTC 8649:8651, Libjingle 8639:8651 (Closed)

Created:
5 years, 9 months ago by magjed_chromium

Modified:
5 years, 9 months ago

Reviewers:
tommi (sloooow) - chröme

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Roll WebRTC 8649:8651, Libjingle 8639:8651 WebRTC 8649:8651 Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/b4c07a0..61b3feb Libjingle 8639:8651 Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/c9f4c13..4138f65 TBR=tommi Committed: https://crrev.com/f497d1fbcf1c0919ba260ed64ac18829b3acf7a0 Cr-Commit-Position: refs/heads/master@{#319635}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	DEPS	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	third_party/libjingle/README.chromium	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/987033002/1

5 years, 9 months ago (2015-03-09 14:59:40 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/f497d1fbcf1c0919ba260ed64ac18829b3acf7a0 Cr-Commit-Position: refs/heads/master@{#319635}

5 years, 9 months ago (2015-03-09 15:35:22 UTC) #4

magjed_chromium

5 years, 9 months ago (2015-03-09 15:46:34 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/989253002/ by magjed@chromium.org.

The reason for reverting is: Broke compilation on Linux
http://build.chromium.org/p/chromium/builders/Linux/builds/59264 with error
message: AttributeError: 'Checker' object has no attribute 'run_js_check'.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages