chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc - Issue 98703003: Mode Indicator using BubbleDelegateView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

Issue 98703003: Mode Indicator using BubbleDelegateView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated based on the review Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/input_method/mode_indicator_controller.h » ('j') | chrome/browser/chromeos/input_method/mode_indicator_delegate_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

diff --git a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc b/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

index c26134e47d7df551ce0e92f6a802f1d20d828306..a49b55f7386b907970b7923fb3e933a039873c14 100644

--- a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

+++ b/chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

@@ -17,7 +17,6 @@

#include "chrome/browser/chromeos/input_method/delayable_widget.h"

#include "chrome/browser/chromeos/input_method/infolist_window_view.h"

#include "chrome/browser/chromeos/input_method/mode_indicator_controller.h"

-#include "chrome/browser/chromeos/input_method/mode_indicator_widget.h"

#include "ui/views/widget/widget.h"

@@ -83,7 +82,7 @@ void CandidateWindowControllerImpl::CreateView() {

// Create the mode indicator controller.

mode_indicator_controller_.reset(

- new ModeIndicatorController(new ModeIndicatorWidget));

+ new ModeIndicatorController(InputMethodManager::Get()));

}

void CandidateWindowControllerImpl::Hide() {