chrome/android/java/src/org/chromium/chrome/browser/Tab.java - Issue 986963002: Allow fullscreen manager and control container to be null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 986963002: Allow fullscreen manager and control container to be null (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed more comments from tedchoc Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

index 2ce12cc916b2309e94e2121074c86af283d52bc9..210119e5b7e51c010a19befbdfc93746d3929bde 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/Tab.java

@@ -2410,8 +2410,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

* {@link TopControlsState} defines the valid return options.

protected int getTopControlsStateConstraints() {

- if (mFullscreenManager == null) return TopControlsState.SHOWN;

boolean enableHidingTopControls = isHidingTopControlsEnabled();

boolean enableShowingTopControls = isShowingTopControlsEnabled();

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/StaticTabSceneLayer.java » ('j') | no next file with comments »