Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_types.cc

Issue 98693017: Some nits I found while looking around rAc() code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_types.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_types.cc b/chrome/browser/ui/autofill/autofill_dialog_types.cc
index f6d6b07f791f3149b1e3529ca1a678e3b7cd85de..54631d48a2cff2cac0189d5b44d8b2750bf845f3 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_types.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_types.cc
@@ -8,7 +8,6 @@
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "grit/generated_resources.h"
-#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
namespace {
@@ -21,6 +20,23 @@ bool IsSureError(const autofill::ValidityMessage& message) {
namespace autofill {
+#ifndef NDEBUG
+std::ostream& operator<<(std::ostream& out, DialogSection section) {
Evan Stade 2014/01/03 20:28:29 I don't think this should be here.
Dan Beam 2014/01/03 20:31:04 it's not in release builds
groby-ooo-7-16 2014/01/04 01:05:45 See previous comment - I think it should be all or
+ switch (section) {
+ case SECTION_CC:
+ return out << "SECTION_CC";
+ case SECTION_BILLING:
+ return out << "SECTION_BILLING";
+ case SECTION_CC_BILLING:
+ return out << "SECTION_CC_BILLING";
+ case SECTION_SHIPPING:
+ return out << "SECTION_SHIPPING";
+ }
+ NOTREACHED();
+ return out;
+}
+#endif
+
static const base::char16 kRangeSeparator = '|';
DialogNotification::DialogNotification() : type_(NONE) {}

Powered by Google App Engine
This is Rietveld 408576698