Issue 98693006: Generate toSVGSVG|Stop|TextContentElement()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98693006: Generate toSVGSVG|Stop|TextContentElement() (Closed)

Created:
7 years ago by gyuyoung-inactive

Modified:
7 years ago

Reviewers:
tkent

CC:
blink-reviews, pdr, Stephen Chennney, krit, f(malita), rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Generate toSVGSVG|Stop|TextContentElement() This cl generate toSVGFoo() for SVGSVGElement, SVGStopElement, and SVGTextContentElement(). We can use more plenty toSVGFoo() functions, and help to detect bad type casts. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163214

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -14 lines)			Patch
M	Source/core/svg/SVGSVGElement.h	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	Source/core/svg/SVGStopElement.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	Source/core/svg/SVGTextContentElement.h	View	1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/98693006/1

7 years ago (2013-12-05 01:57:49 UTC) #3

Message was sent while issue was closed.

Change committed as 163214

Expand Messages | Collapse Messages