Issue 986873002: Set the chromium_code GYP variable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 986873002: Set the chromium_code GYP variable (Closed)

Created:
5 years, 9 months ago by Mark Mentovai

Modified:
5 years, 9 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

Set the chromium_code GYP variable. When building in the Chromium tree, chromium_code is necessary to apply Chromium’s build/filename_rules.gypi. Crashpad’s build depends on these rules. chromium_code also enables a high warning level, which is desirable for Crashpad. BUG=crashpad:12 R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/b770a51f2bdfb3c59dd6a3283f8a8e229d4e76ec

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -0 lines)			Patch
A	build/crashpad.gypi	View	1 chunk	+23 lines, -0 lines	0 comments	Download
M	client/client.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	compat/compat.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	handler/handler.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	minidump/minidump.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	snapshot/snapshot.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/tools.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	util/util.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Mark Mentovai

5 years, 9 months ago (2015-03-08 19:17:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b770a51f2bdfb3c59dd6a3283f8a8e229d4e76ec (presubmit successful).