Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1568)

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 986843002: Scaffold for MD-Settings, inside chrome://md-settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Expand scaffold and add to chrome://md-settings (point of this CL) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_main/settings_main.html
diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html
index b4686e0ae6e2750007a1e32aab1ac6f27eab4031..8dc8db695143d3ae5cfa78402d2d8e5f27b62b2c 100644
--- a/chrome/browser/resources/settings/settings_main/settings_main.html
+++ b/chrome/browser/resources/settings/settings_main/settings_main.html
@@ -2,17 +2,29 @@
<link rel="import" href="chrome://resources/polymer/core-animated-pages/core-animated-pages.html">
<link rel="import" href="chrome://resources/polymer/core-transition/core-transition.html">
<link rel="import" href="chrome://resources/polymer/paper-shadow/paper-shadow.html">
+<link rel="import" href="chrome://md-settings/a11y_page/a11y_page.html">
+<link rel="import" href="chrome://md-settings/dummy_page/dummy_page.html">
+<link rel="import" href="chrome://md-settings/help_pane/help_pane.html">
+<link rel="import" href="chrome://md-settings/utils/utils.html">
<polymer-element name="cr-settings-main">
<template>
<link rel="stylesheet" href="settings_main.css">
- <div id="container">
- <paper-shadow>
- <core-animated-pages id="pages" selected="{{selectedPageId}}"
- valueattr="PAGE_ID" transitions="cross-fade">
- <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page>
+ <div layout horizontal id="container">
+ <paper-shadow flex two>
+ <core-animated-pages id="pages" valueattr="PAGE_ID"
+ selected="{{selectedPageId}}" selectedIndex="{{selectedPageIndex}}"
+ excludedLocalNames="template" transitions="cross-fade">
+ <template if="{{isChromeOs()}}">
+ <cr-settings-a11y-page prefs="{{prefs}}"></cr-settings-a11y-page>
+ </template>
+ <cr-settings-dummy-page prefs="{{prefs}}"></cr-settings-dummy-page>
</core-animated-pages>
</paper-shadow>
+ <!-- TODO(michaelpg): Animate this as with core-animated-pages. -->
+ <cr-help-pane id="help" flex
+ helpArticles="{{pages.length && pages[selectedPageIndex].helpArticles}}">
+ </cr-help-pane>
</div>
</template>
<script src="settings_main.js"></script>

Powered by Google App Engine
This is Rietveld 408576698