Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4960)

Unified Diff: chrome/browser/resources/settings/settings_drawer/settings_drawer.js

Issue 986843002: Scaffold for MD-Settings, inside chrome://md-settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Expand scaffold and add to chrome://md-settings (point of this CL) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/settings_drawer/settings_drawer.js
diff --git a/chrome/browser/resources/settings/settings_drawer/settings_drawer.js b/chrome/browser/resources/settings/settings_drawer/settings_drawer.js
index 7cbd9da99f82244f2eedbee2ae58b8a70e44590a..d09e9061b7c2506885adbb5813ceef213cbc3594 100644
--- a/chrome/browser/resources/settings/settings_drawer/settings_drawer.js
+++ b/chrome/browser/resources/settings/settings_drawer/settings_drawer.js
@@ -10,10 +10,9 @@
* Example:
*
* <core-drawer-panel>
- * <cr-settings-drawer drawer selectedId="{{selectedId}}"
- * pages="{{pages}}">
+ * <cr-settings-drawer drawer selectedIndex="{{index}}" pages="{{pages}}">
* </cr-settings-drawer>
- * <cr-settings-main main selectedId="{{selectedId}}" pages="{{pages}}">
+ * <cr-settings-main main currentPageIndex="{{index}}" pages="{{pages}}">
* </cr-settings-main>
* </core-drawer-panel>
*
@@ -26,7 +25,7 @@ Polymer('cr-settings-drawer', {
* Pages to include in the navigation.
*
* @attribute pages
- * @type Array<!Object>
+ * @type Array<!CrSettingsPage>
* @default null
*/
pages: null,
@@ -34,11 +33,20 @@ Polymer('cr-settings-drawer', {
/**
* ID of the currently selected page.
*
- * @attribute selectedId
+ * @attribute selectedIndex
* @type string
* default ''
*/
selectedId: '',
+
+ /**
+ * Index of the currently selected page.
+ *
+ * @attribute selectedIndex
+ * @type number
+ * default 0
+ */
+ selectedIndex: 0,
},
/** @override */

Powered by Google App Engine
This is Rietveld 408576698