Issue 986793002: Fix hit-testing of elements with the same z-index.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 986793002: Fix hit-testing of elements with the same z-index. (Closed)

Created:
5 years, 9 months ago by ojan

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium, eseidel

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix hit-testing of elements with the same z-index. hit-testing needs to walk in backwards order from paint. The previous attempt at reverse sorting by z-index didn't reverse things with the same z-index. Instead, forward sort the same way as we do with paint and then reverse the whole vector. R=abarth@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8578ab267bc10446adc7cc5a076ca1d695644387

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+111 lines, -8 lines)			Patch
M	sky/engine/core/rendering/RenderBox.cpp	View	3 chunks	+7 lines, -8 lines	0 comments	Download
A	sky/tests/layout/document-elementFromPoint-absolute-position.sky	View	1 chunk	+92 lines, -0 lines	0 comments	Download
A	sky/tests/layout/document-elementFromPoint-absolute-position-expected.txt	View	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

ojan

5 years, 9 months ago (2015-03-06 23:53:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8578ab267bc10446adc7cc5a076ca1d695644387 (presubmit successful).