Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 986763002: Revert of [MemSherrif] Uninitialized Read (Closed)

Created:
5 years, 9 months ago by bungeman-skia
Modified:
5 years, 9 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [MemSherrif] Uninitialized Read (patchset #1 id:1 of https://codereview.chromium.org/969073002/) Reason for revert: Uninitialized read should now be fixed (and there is a test). Should this revert break the DrMemory bots, this revert should be reverted. Original issue's description: > [MemSherrif] Uninitialized Read > > BUG=463204 > TBR=reed@chromium.org, thestig@chromium.org > > Committed: https://crrev.com/94d1b7498d7b5c4fc25e3337be117f8c9ef1dbf2 > Cr-Commit-Position: refs/heads/master@{#318760} TBR=thestig@chromium.org,groby@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=463204 Committed: https://crrev.com/82417f64ce69c98a93f82f59e6adda1c9c2e510c Cr-Commit-Position: refs/heads/master@{#319503}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M tools/valgrind/drmemory/suppressions.txt View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
bungeman-skia
Created Revert of [MemSherrif] Uninitialized Read
5 years, 9 months ago (2015-03-06 20:56:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986763002/1
5 years, 9 months ago (2015-03-06 20:59:09 UTC) #2
commit-bot: I haz the power
Failed to apply patch for tools/valgrind/drmemory/suppressions.txt: While running git apply --index -3 -p1; error: patch ...
5 years, 9 months ago (2015-03-06 21:00:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986763002/40001
5 years, 9 months ago (2015-03-06 21:05:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-06 21:07:09 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/82417f64ce69c98a93f82f59e6adda1c9c2e510c Cr-Commit-Position: refs/heads/master@{#319503}
5 years, 9 months ago (2015-03-06 21:07:50 UTC) #8
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-06 21:19:45 UTC) #9
groby-ooo-7-16
On 2015/03/06 21:19:45, Lei Zhang wrote: > lgtm lgtm ++
5 years, 9 months ago (2015-03-06 21:51:23 UTC) #10
Lei Zhang
5 years, 9 months ago (2015-03-07 03:59:47 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:40001) has been created in
https://codereview.chromium.org/984073007/ by thestig@chromium.org.

The reason for reverting is: DrMemory bots still hit the bug:
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Content%20...
.

Powered by Google App Engine
This is Rietveld 408576698