Issue 986753002: Add back didMount

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 986753002: Add back didMount (Closed)

Created:
5 years, 9 months ago by rafaelw

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add back didMount Sorry I keep changing my mind about this. My thinking had been since this was computable by just setting a bit and checking it in render(), that it was silly, but I keep finding uses for it and it's annoying to re-implement in each component. TBR=eseidel BUG= Committed: https://chromium.googlesource.com/external/mojo/+/831d65b0c49a33d1bb201dbbaaf5047e9626b90e

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	sky/framework/fn.dart	View		3 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

rafaelw

5 years, 9 months ago (2015-03-06 20:50:53 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
831d65b0c49a33d1bb201dbbaaf5047e9626b90e (presubmit successful).

Expand Messages | Collapse Messages