sync/internal_api/public/attachments/in_memory_attachment_store.h - Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/attachments/in_memory_attachment_store.h

Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/attachments/attachment_store_handle.h ('k') | sync/internal_api/public/attachments/on_disk_attachment_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/attachments/in_memory_attachment_store.h

diff --git a/sync/internal_api/public/attachments/in_memory_attachment_store.h b/sync/internal_api/public/attachments/in_memory_attachment_store.h

index 9fd0b851dacb7187f4adae10a16accd0a32fb759..5f8599258d3bf333392b954c8b8693e2696034d5 100644

--- a/sync/internal_api/public/attachments/in_memory_attachment_store.h

+++ b/sync/internal_api/public/attachments/in_memory_attachment_store.h

@@ -10,6 +10,7 @@

#include "sync/api/attachments/attachment.h"

#include "sync/api/attachments/attachment_id.h"

#include "sync/api/attachments/attachment_store.h"

+#include "sync/api/attachments/attachment_store_backend.h"

#include "sync/base/sync_export.h"

namespace base {

@@ -32,14 +33,17 @@ class SYNC_EXPORT InMemoryAttachmentStore : public AttachmentStoreBackend,

void Init(const AttachmentStore::InitCallback& callback) override;

void Read(const AttachmentIdList& ids,

const AttachmentStore::ReadCallback& callback) override;

- void Write(const AttachmentList& attachments,

+ void Write(AttachmentStore::AttachmentReferrer referrer,

+ const AttachmentList& attachments,

const AttachmentStore::WriteCallback& callback) override;

- void Drop(const AttachmentIdList& ids,

+ void Drop(AttachmentStore::AttachmentReferrer referrer,

+ const AttachmentIdList& ids,

const AttachmentStore::DropCallback& callback) override;

void ReadMetadata(

const AttachmentIdList& ids,

const AttachmentStore::ReadMetadataCallback& callback) override;

void ReadAllMetadata(

+ AttachmentStore::AttachmentReferrer referrer,

const AttachmentStore::ReadMetadataCallback& callback) override;

private: