sync/internal_api/public/attachments/attachment_service_proxy.h - Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/attachments/attachment_service_proxy.h

Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/attachments/attachment_service_impl.h ('k') | sync/internal_api/public/attachments/attachment_store_frontend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/attachments/attachment_service_proxy.h

diff --git a/sync/internal_api/public/attachments/attachment_service_proxy.h b/sync/internal_api/public/attachments/attachment_service_proxy.h

index 3a9666065d927bc4b9d88284657919c04f9ef923..ef6e287f676aa1130b49f6b1868548f388d95f6f 100644

--- a/sync/internal_api/public/attachments/attachment_service_proxy.h

+++ b/sync/internal_api/public/attachments/attachment_service_proxy.h

@@ -50,10 +50,6 @@ class SYNC_EXPORT AttachmentServiceProxy : public AttachmentService {

~AttachmentServiceProxy() override;

- // AttachmentService implementation.

- //

- // GetStore always returns NULL.

- AttachmentStore* GetStore() override;

void GetOrDownloadAttachments(const AttachmentIdList& attachment_ids,

const GetOrDownloadCallback& callback) override;

void UploadAttachments(const AttachmentIdSet& attachment_ids) override;

@@ -79,7 +75,6 @@ class SYNC_EXPORT AttachmentServiceProxy : public AttachmentService {

Core(const base::WeakPtr<syncer::AttachmentService>& wrapped);

// AttachmentService implementation.

- AttachmentStore* GetStore() override;

void GetOrDownloadAttachments(

const AttachmentIdList& attachment_ids,

const GetOrDownloadCallback& callback) override;