sync/internal_api/attachments/on_disk_attachment_store.cc - Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/on_disk_attachment_store.cc

Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/attachments/in_memory_attachment_store_unittest.cc ('k') | sync/internal_api/attachments/on_disk_attachment_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/attachments/on_disk_attachment_store.cc

diff --git a/sync/internal_api/attachments/on_disk_attachment_store.cc b/sync/internal_api/attachments/on_disk_attachment_store.cc

index 7b715e03b7e7b254ecf6db283f285d218be9808f..ec6fc75931bd9283d50033f4b055f9f52f514717 100644

--- a/sync/internal_api/attachments/on_disk_attachment_store.cc

+++ b/sync/internal_api/attachments/on_disk_attachment_store.cc

@@ -134,6 +134,7 @@ void OnDiskAttachmentStore::Read(

}

void OnDiskAttachmentStore::Write(

+ AttachmentStore::AttachmentReferrer referrer,

const AttachmentList& attachments,

const AttachmentStore::WriteCallback& callback) {

DCHECK(CalledOnValidThread());

@@ -153,6 +154,7 @@ void OnDiskAttachmentStore::Write(

}

void OnDiskAttachmentStore::Drop(

+ AttachmentStore::AttachmentReferrer referrer,

const AttachmentIdList& ids,

const AttachmentStore::DropCallback& callback) {

DCHECK(CalledOnValidThread());

@@ -206,6 +208,7 @@ void OnDiskAttachmentStore::ReadMetadata(

}

void OnDiskAttachmentStore::ReadAllMetadata(

+ AttachmentStore::AttachmentReferrer referrer,

const AttachmentStore::ReadMetadataCallback& callback) {

DCHECK(CalledOnValidThread());

AttachmentStore::Result result_code =