sync/internal_api/attachments/attachment_service_proxy.cc - Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/attachment_service_proxy.cc

Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/attachments/attachment_service_impl_unittest.cc ('k') | sync/internal_api/attachments/attachment_service_proxy_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/attachments/attachment_service_proxy.cc

diff --git a/sync/internal_api/attachments/attachment_service_proxy.cc b/sync/internal_api/attachments/attachment_service_proxy.cc

index 92104ced5dbb6c6124bdbb4d00df445fea7220a7..50b7a64989f08c544f080c348abf872a505d68df 100644

--- a/sync/internal_api/attachments/attachment_service_proxy.cc

+++ b/sync/internal_api/attachments/attachment_service_proxy.cc

@@ -49,10 +49,6 @@ AttachmentServiceProxy::AttachmentServiceProxy(

AttachmentServiceProxy::~AttachmentServiceProxy() {

}

-AttachmentStore* AttachmentServiceProxy::GetStore() {

- return NULL;

void AttachmentServiceProxy::GetOrDownloadAttachments(

const AttachmentIdList& attachment_ids,

const GetOrDownloadCallback& callback) {

@@ -85,10 +81,6 @@ AttachmentServiceProxy::Core::Core(

AttachmentServiceProxy::Core::~Core() {

}

-AttachmentStore* AttachmentServiceProxy::Core::GetStore() {

- return NULL;

void AttachmentServiceProxy::Core::GetOrDownloadAttachments(

const AttachmentIdList& attachment_ids,

const GetOrDownloadCallback& callback) {