sync/internal_api/attachments/on_disk_attachment_store_unittest.cc - Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/on_disk_attachment_store_unittest.cc

Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/internal_api/attachments/attachment_service_impl.cc ('K') | « sync/internal_api/attachments/on_disk_attachment_store.cc ('k') | sync/internal_api/public/attachments/attachment_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/attachments/on_disk_attachment_store_unittest.cc

diff --git a/sync/internal_api/attachments/on_disk_attachment_store_unittest.cc b/sync/internal_api/attachments/on_disk_attachment_store_unittest.cc

index e46f060216094041516edca0248e1a323c4f1dab..4dcc8f86c6ba02b0fba55dd340a6c09963fefe78 100644

--- a/sync/internal_api/attachments/on_disk_attachment_store_unittest.cc

+++ b/sync/internal_api/attachments/on_disk_attachment_store_unittest.cc

@@ -37,9 +37,9 @@ class OnDiskAttachmentStoreFactory {

OnDiskAttachmentStoreFactory() {}

~OnDiskAttachmentStoreFactory() {}

- scoped_refptr<AttachmentStore> CreateAttachmentStore() {

+ scoped_ptr<AttachmentStore> CreateAttachmentStore() {

EXPECT_TRUE(temp_dir_.CreateUniqueTempDir());

- scoped_refptr<AttachmentStore> store;

+ scoped_ptr<AttachmentStore> store;

AttachmentStore::Result result = AttachmentStore::UNSPECIFIED_ERROR;

store = AttachmentStore::CreateOnDiskStore(

temp_dir_.path(), base::ThreadTaskRunnerHandle::Get(),

@@ -64,7 +64,7 @@ class OnDiskAttachmentStoreSpecificTest : public testing::Test {

base::ScopedTempDir temp_dir_;

base::FilePath db_path_;

base::MessageLoop message_loop_;

- scoped_refptr<AttachmentStore> store_;

+ scoped_ptr<AttachmentStore> store_;

OnDiskAttachmentStoreSpecificTest() {}