sync/internal_api/attachments/in_memory_attachment_store.cc - Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/in_memory_attachment_store.cc

Issue 986743004: [Sync] Refactor AttachmentStore classes. Introduce concept of referrer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/internal_api/attachments/attachment_service_impl.cc ('K') | « sync/internal_api/attachments/attachment_store_test_template.h ('k') | sync/internal_api/attachments/in_memory_attachment_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/attachments/in_memory_attachment_store.cc

diff --git a/sync/internal_api/attachments/in_memory_attachment_store.cc b/sync/internal_api/attachments/in_memory_attachment_store.cc

index d2a2083ea14750cb48f036c07ed18df537a3eb7a..ba2142663456b232623c52c0ef35fce0493bee26 100644

--- a/sync/internal_api/attachments/in_memory_attachment_store.cc

+++ b/sync/internal_api/attachments/in_memory_attachment_store.cc

@@ -66,6 +66,7 @@ void InMemoryAttachmentStore::Read(

}

void InMemoryAttachmentStore::Write(

+ AttachmentStore::AttachmentReferrer referrer,

const AttachmentList& attachments,

const AttachmentStore::WriteCallback& callback) {

DCHECK(CalledOnValidThread());

@@ -78,6 +79,7 @@ void InMemoryAttachmentStore::Write(

}

void InMemoryAttachmentStore::Drop(

+ AttachmentStore::AttachmentReferrer referrer,

const AttachmentIdList& ids,

const AttachmentStore::DropCallback& callback) {

DCHECK(CalledOnValidThread());

@@ -115,6 +117,7 @@ void InMemoryAttachmentStore::ReadMetadata(

}

void InMemoryAttachmentStore::ReadAllMetadata(

+ AttachmentStore::AttachmentReferrer referrer,

const AttachmentStore::ReadMetadataCallback& callback) {

DCHECK(CalledOnValidThread());

AttachmentStore::Result result_code = AttachmentStore::SUCCESS;