Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 986743003: Upstream (most of) ios/web/public (Closed)

Created:
5 years, 9 months ago by stuartmorgan
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream (most of) ios/web/public This upstreams the bulk of ios/web/public. Mostly this is new files, but also some diffs to existing files (where those don't introduce build dependencies that aren't available yet). All files in this CL are added to the build. BUG=464810 Committed: https://crrev.com/8084e61dc6ef3b33928b6feb5ef615c9728abf88 Cr-Commit-Position: refs/heads/master@{#319554}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix namespace comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1569 lines, -81 lines) Patch
M ios/web/ios_web.gyp View 2 chunks +25 lines, -1 line 0 comments Download
M ios/web/ios_web_unittests.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
A ios/web/net/cert_policy.cc View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/web/net/cert_policy_unittest.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A ios/web/net/certificate_policy_cache.cc View 1 chunk +38 lines, -0 lines 0 comments Download
A ios/web/public/browser_url_rewriter.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ios/web/public/cert_policy.h View 1 chunk +55 lines, -0 lines 0 comments Download
A ios/web/public/certificate_policy_cache.h View 1 chunk +56 lines, -0 lines 0 comments Download
A + ios/web/public/favicon_url.h View 2 chunks +7 lines, -8 lines 0 comments Download
A + ios/web/public/favicon_url.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A ios/web/public/interstitials/web_interstitial.h View 1 chunk +64 lines, -0 lines 0 comments Download
A ios/web/public/interstitials/web_interstitial_delegate.h View 1 chunk +33 lines, -0 lines 0 comments Download
A ios/web/public/referrer_util.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ios/web/public/referrer_util.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A ios/web/public/referrer_util_unittest.cc View 1 chunk +116 lines, -0 lines 0 comments Download
M ios/web/public/test/crw_test_js_injection_receiver.mm View 1 chunk +4 lines, -0 lines 0 comments Download
A ios/web/public/url_util.h View 1 chunk +17 lines, -0 lines 0 comments Download
A ios/web/public/user_metrics.h View 1 chunk +27 lines, -0 lines 0 comments Download
M ios/web/public/web_client.h View 4 chunks +10 lines, -0 lines 0 comments Download
D ios/web/public/web_client.cc View 1 chunk +0 lines, -68 lines 0 comments Download
A + ios/web/public/web_client.mm View 3 chunks +10 lines, -0 lines 0 comments Download
A ios/web/public/web_state/crw_native_content.h View 1 chunk +92 lines, -0 lines 0 comments Download
A ios/web/public/web_state/crw_native_content_provider.h View 1 chunk +34 lines, -0 lines 0 comments Download
A ios/web/public/web_state/crw_web_controller_observer.h View 1 chunk +89 lines, -0 lines 0 comments Download
A ios/web/public/web_state/crw_web_delegate.h View 1 chunk +266 lines, -0 lines 0 comments Download
A ios/web/public/web_state/crw_web_user_interface_delegate.h View 1 chunk +64 lines, -0 lines 0 comments Download
M ios/web/public/web_state/js/crw_js_injection_evaluator.h View 2 chunks +6 lines, -0 lines 0 comments Download
A ios/web/public/web_state/url_verification_constants.h View 1 chunk +20 lines, -0 lines 0 comments Download
M ios/web/public/web_state/web_state_observer.h View 3 chunks +24 lines, -0 lines 0 comments Download
A ios/web/public/web_state/web_state_observer_bridge.h View 1 1 chunk +75 lines, -0 lines 0 comments Download
A ios/web/public/web_view_type.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/web/url_util.cc View 1 chunk +18 lines, -0 lines 0 comments Download
A ios/web/url_util_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download
A ios/web/user_metrics.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M ios/web/web_state/js/crw_js_injection_receiver.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/web_state/web_state_observer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/web/web_state/web_state_observer_bridge.mm View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
stuartmorgan
This is pure upstreaming; no edits or forking
5 years, 9 months ago (2015-03-06 20:47:51 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/986743003/diff/1/ios/web/public/web_state/web_state_observer_bridge.h File ios/web/public/web_state/web_state_observer_bridge.h (right): https://codereview.chromium.org/986743003/diff/1/ios/web/public/web_state/web_state_observer_bridge.h#newcode73 ios/web/public/web_state/web_state_observer_bridge.h:73: } // namespace NIT: web
5 years, 9 months ago (2015-03-06 22:43:12 UTC) #3
stuartmorgan
https://codereview.chromium.org/986743003/diff/1/ios/web/public/web_state/web_state_observer_bridge.h File ios/web/public/web_state/web_state_observer_bridge.h (right): https://codereview.chromium.org/986743003/diff/1/ios/web/public/web_state/web_state_observer_bridge.h#newcode73 ios/web/public/web_state/web_state_observer_bridge.h:73: } // namespace On 2015/03/06 22:43:12, eugenebut wrote: > ...
5 years, 9 months ago (2015-03-06 22:47:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986743003/20001
5 years, 9 months ago (2015-03-06 22:49:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 00:52:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986743003/20001
5 years, 9 months ago (2015-03-07 04:50:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-07 04:51:48 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 04:52:45 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8084e61dc6ef3b33928b6feb5ef615c9728abf88
Cr-Commit-Position: refs/heads/master@{#319554}

Powered by Google App Engine
This is Rietveld 408576698