Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: src/x64/lithium-x64.h

Issue 98673003: Fix HInnerAllocatedObject to use an HValue for the offset. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1728 matching lines...) Expand 10 before | Expand all | Expand 10 after
1739 LOperand* function() { return inputs_[0]; } 1739 LOperand* function() { return inputs_[0]; }
1740 LOperand* code_object() { return temps_[0]; } 1740 LOperand* code_object() { return temps_[0]; }
1741 1741
1742 virtual void PrintDataTo(StringStream* stream); 1742 virtual void PrintDataTo(StringStream* stream);
1743 1743
1744 DECLARE_CONCRETE_INSTRUCTION(StoreCodeEntry, "store-code-entry") 1744 DECLARE_CONCRETE_INSTRUCTION(StoreCodeEntry, "store-code-entry")
1745 DECLARE_HYDROGEN_ACCESSOR(StoreCodeEntry) 1745 DECLARE_HYDROGEN_ACCESSOR(StoreCodeEntry)
1746 }; 1746 };
1747 1747
1748 1748
1749 class LInnerAllocatedObject V8_FINAL: public LTemplateInstruction<1, 1, 0> { 1749 class LInnerAllocatedObject V8_FINAL: public LTemplateInstruction<1, 2, 0> {
1750 public: 1750 public:
1751 explicit LInnerAllocatedObject(LOperand* base_object) { 1751 LInnerAllocatedObject(LOperand* base_object, LOperand* offset) {
1752 inputs_[0] = base_object; 1752 inputs_[0] = base_object;
1753 inputs_[1] = offset;
1753 } 1754 }
1754 1755
1755 LOperand* base_object() { return inputs_[0]; } 1756 LOperand* base_object() const { return inputs_[0]; }
1756 int offset() { return hydrogen()->offset(); } 1757 LOperand* offset() const { return inputs_[1]; }
1757 1758
1758 virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE; 1759 virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE;
1759 1760
1760 DECLARE_CONCRETE_INSTRUCTION(InnerAllocatedObject, "sub-allocated-object") 1761 DECLARE_CONCRETE_INSTRUCTION(InnerAllocatedObject, "inner-allocated-object")
1761 DECLARE_HYDROGEN_ACCESSOR(InnerAllocatedObject)
1762 }; 1762 };
1763 1763
1764 1764
1765 class LThisFunction V8_FINAL : public LTemplateInstruction<1, 0, 0> { 1765 class LThisFunction V8_FINAL : public LTemplateInstruction<1, 0, 0> {
1766 public: 1766 public:
1767 DECLARE_CONCRETE_INSTRUCTION(ThisFunction, "this-function") 1767 DECLARE_CONCRETE_INSTRUCTION(ThisFunction, "this-function")
1768 DECLARE_HYDROGEN_ACCESSOR(ThisFunction) 1768 DECLARE_HYDROGEN_ACCESSOR(ThisFunction)
1769 }; 1769 };
1770 1770
1771 1771
(...skipping 1071 matching lines...) Expand 10 before | Expand all | Expand 10 after
2843 2843
2844 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2844 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2845 }; 2845 };
2846 2846
2847 #undef DECLARE_HYDROGEN_ACCESSOR 2847 #undef DECLARE_HYDROGEN_ACCESSOR
2848 #undef DECLARE_CONCRETE_INSTRUCTION 2848 #undef DECLARE_CONCRETE_INSTRUCTION
2849 2849
2850 } } // namespace v8::int 2850 } } // namespace v8::int
2851 2851
2852 #endif // V8_X64_LITHIUM_X64_H_ 2852 #endif // V8_X64_LITHIUM_X64_H_
OLDNEW
« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x64/lithium-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698