Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: lib/devc.dart

Issue 986723002: Add JavaScriptSourceNode to represent runtime libraries (fixes #85) (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/dependency_graph.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/devc.dart
diff --git a/lib/devc.dart b/lib/devc.dart
index f2f548e0fdbbdf514074618643367c9c83d9a536..95246c146fea4e712389748c3e42c162a02e692d 100644
--- a/lib/devc.dart
+++ b/lib/devc.dart
@@ -51,7 +51,6 @@ class Compiler {
List<LibraryInfo> _libraries = <LibraryInfo>[];
final List<CodeGenerator> _generators;
bool _failure = false;
- bool _devCompilerRuntimeCopied = false;
factory Compiler(CompilerOptions options,
[TypeResolver resolver, CheckerReporter reporter]) {
@@ -99,6 +98,8 @@ class Compiler {
_buildHtmlFile(node);
} else if (node is DartSourceNode) {
_buildDartLibrary(node);
+ } else if (node is JavaScriptSourceNode) {
+ _buildJavaScriptFile(node);
} else {
assert(false); // should not get a build request on PartSourceNode
}
@@ -119,19 +120,19 @@ class Compiler {
String outputFile = path.join(_options.outputDir, filename);
new File(outputFile).writeAsStringSync(output);
- if (_options.outputDart || _devCompilerRuntimeCopied) return;
- // Copy the dev_compiler runtime (implicit dependency for js codegen)
- // TODO(sigmund): split this out as a separate node in our dependency graph
- // (https://github.com/dart-lang/dev_compiler/issues/85).
- var runtimeDir = path.join(
- path.dirname(path.dirname(Platform.script.path)), 'lib/runtime/');
- var runtimeOutput = path.join(_options.outputDir, 'dev_compiler/runtime/');
- new Directory(runtimeOutput).createSync(recursive: true);
- new File(path.join(runtimeDir, 'harmony_feature_check.js'))
- .copy(path.join(runtimeOutput, 'harmony_feature_check.js'));
- new File(path.join(runtimeDir, 'dart_runtime.js'))
- .copy(path.join(runtimeOutput, 'dart_runtime.js'));
- _devCompilerRuntimeCopied = true;
+ if (_options.outputDart) return;
+ }
+
+ void _buildJavaScriptFile(JavaScriptSourceNode node) {
+ // JavaScriptSourceNodes are runtime .js files that just need to be copied
+ // over to the output location. These can be external dependencies or pieces
+ // of the dev_compiler runtime.
+ if (_options.outputDir == null || _options.outputDart) return;
+ assert(node.uri.scheme == 'package');
+ var filepath = path.join(_options.outputDir, node.uri.path);
+ var dir = path.dirname(filepath);
+ new Directory(dir).createSync(recursive: true);
+ new File(filepath).writeAsStringSync(node.source.contents.data);
}
bool _isEntry(DartSourceNode node) {
« no previous file with comments | « no previous file | lib/src/dependency_graph.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698