Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 986683002: [Android] Allow specifying the progress component of the toolbar as a separate texture. (Closed)

Created:
5 years, 9 months ago by Ted C
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Allow specifying the progress component of the toolbar as a separate texture. The progress bar changes much more often than the contents of the toolbar, so splitting the two will allow for cheaper updates to the toolbar texture. BUG=461148 Committed: https://crrev.com/a18c5707b6338c036bcd3057183a96c79988f339 Cr-Commit-Position: refs/heads/master@{#319523}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add capture method. #

Patch Set 3 : Javadoc fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java View 4 chunks +60 lines, -0 lines 0 comments Download
M chrome/browser/android/compositor/layer/tab_layer.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/android/compositor/layer/toolbar_layer.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/android/compositor/layer/toolbar_layer.cc View 3 chunks +29 lines, -4 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/resources/dynamics/ViewResourceAdapter.java View 1 2 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ted C
PTAL
5 years, 9 months ago (2015-03-06 17:53:55 UTC) #2
David Trainor- moved to gerrit
lgtm https://chromiumcodereview.appspot.com/986683002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java File chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java (right): https://chromiumcodereview.appspot.com/986683002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java#newcode38 chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java:38: void onProgressVisibilityChanged(int visibility); I'm fine either way, but ...
5 years, 9 months ago (2015-03-06 18:35:16 UTC) #3
Ted C
https://chromiumcodereview.appspot.com/986683002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java File chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java (right): https://chromiumcodereview.appspot.com/986683002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java#newcode38 chrome/android/java/src/org/chromium/chrome/browser/widget/SmoothProgressBar.java:38: void onProgressVisibilityChanged(int visibility); On 2015/03/06 18:35:16, David Trainor wrote: ...
5 years, 9 months ago (2015-03-06 21:32:24 UTC) #4
David Trainor- moved to gerrit
lgtm
5 years, 9 months ago (2015-03-06 21:33:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986683002/40001
5 years, 9 months ago (2015-03-06 21:36:53 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-06 23:07:03 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 23:07:49 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a18c5707b6338c036bcd3057183a96c79988f339
Cr-Commit-Position: refs/heads/master@{#319523}

Powered by Google App Engine
This is Rietveld 408576698