Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4295)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java

Issue 986653004: Add fullscreen permission controls to settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java
index 757b79b5d28f86e5a47881a87ba879b42b25535d..8c98fe0a8c1191b166c6dd4c1b2a064058b7ac83 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsiteSettingsCategoryFilter.java
@@ -16,6 +16,7 @@ public class WebsiteSettingsCategoryFilter {
private static final String FILTER_CAMERA_MIC = "use_camera_or_mic";
private static final String FILTER_JAVASCRIPT = "javascript";
private static final String FILTER_DEVICE_LOCATION = "device_location";
+ private static final String FILTER_FULLSCREEN = "fullscreen";
private static final String FILTER_USE_STORAGE = "use_storage";
private static final String FILTER_POPUPS = "popups";
public static final String FILTER_PUSH_NOTIFICATIONS = "push_notifications";
@@ -39,6 +40,8 @@ public class WebsiteSettingsCategoryFilter {
return ContentSettingsType.CONTENT_SETTINGS_TYPE_NOTIFICATIONS;
} else if (showJavaScriptSites(key)) {
return ContentSettingsType.CONTENT_SETTINGS_TYPE_JAVASCRIPT;
+ } else if (showFullscreenSites(key)) {
+ return ContentSettingsType.CONTENT_SETTINGS_TYPE_FULLSCREEN;
}
return -1;
}
@@ -77,6 +80,14 @@ public class WebsiteSettingsCategoryFilter {
/**
* @param filterValue A category value.
+ * @return Whether the category passed is the fullscreen category.
+ */
+ public boolean showFullscreenSites(String filterValue) {
+ return filterValue.equals(FILTER_FULLSCREEN);
+ }
+
+ /**
+ * @param filterValue A category value.
* @return Whether the category passed is the geolocation category.
*/
public boolean showGeolocationSites(String filterValue) {

Powered by Google App Engine
This is Rietveld 408576698