Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 986643003: Fixed an ignored return value introduced by the ResourceLoaderBridge removal (Closed)

Created:
5 years, 9 months ago by oystein (OOO til 10th of July)
Modified:
5 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed an ignored return value introduced by the ResourceLoaderBridge removal This caused use-after-free crashes when the ThreadedParserReceiver feature is enabled. R=jam BUG=277124 Committed: https://crrev.com/43018bb8439ce89eaa49731647aef5be8216a6b3 Cr-Commit-Position: refs/heads/master@{#319651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/child/web_url_loader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
oystein (OOO til 10th of July)
ptal :)
5 years, 9 months ago (2015-03-06 23:13:00 UTC) #1
jam
lgtm, thanks for the fix
5 years, 9 months ago (2015-03-09 15:40:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986643003/1
5 years, 9 months ago (2015-03-09 15:41:40 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 16:36:51 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 16:37:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43018bb8439ce89eaa49731647aef5be8216a6b3
Cr-Commit-Position: refs/heads/master@{#319651}

Powered by Google App Engine
This is Rietveld 408576698