Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 986623004: base: Put DISALLOW_COPY_AND_ASSIGN inside private section of classes. (Closed)

Created:
5 years, 9 months ago by danakj
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Put DISALLOW_COPY_AND_ASSIGN inside private section of classes. This macro should be private to make the constructors hidden, making them fail at compile time if called, instead of at link time. R=Nico BUG=464816, 447156 Committed: https://crrev.com/71ef42db8b96ccd621e5df2421c375a8725ca872 Cr-Commit-Position: refs/heads/master@{#319568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M base/containers/stack_container.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/files/file_path_watcher_browsertest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/observer_list_threadsafe.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/prefs/pref_member.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/system_monitor/system_monitor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/mock_devices_changed_observer.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/threading/thread_local_storage.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
danakj
5 years, 9 months ago (2015-03-06 23:20:01 UTC) #1
Nico
lgtm also bug 447515, 447156
5 years, 9 months ago (2015-03-06 23:24:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986623004/1
5 years, 9 months ago (2015-03-07 00:02:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 01:21:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986623004/1
5 years, 9 months ago (2015-03-07 17:16:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-07 23:04:32 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 23:05:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71ef42db8b96ccd621e5df2421c375a8725ca872
Cr-Commit-Position: refs/heads/master@{#319568}

Powered by Google App Engine
This is Rietveld 408576698