Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 986583004: Run Valgrind bots with --nogpu and --nocpu as appropriate (Closed)

Created:
5 years, 9 months ago by borenet
Modified:
5 years, 9 months ago
Reviewers:
mtklein, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Run Valgrind bots with --nogpu and --nocpu as appropriate BUG=skia:3506 NOPRESUBMIT=true Committed: https://skia.googlesource.com/skia/+/13e51f91ef39597430de8f318263f105ce14ba40

Patch Set 1 #

Patch Set 2 : nanobench #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M tools/dm_flags.json View 2 chunks +28 lines, -1 line 0 comments Download
M tools/dm_flags.py View 2 chunks +6 lines, -1 line 0 comments Download
M tools/nanobench_flags.json View 1 2 chunks +22 lines, -2 lines 0 comments Download
M tools/nanobench_flags.py View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
borenet
5 years, 9 months ago (2015-03-06 20:27:49 UTC) #2
mtklein
lgtm Neat, this works fine even before we switch up the bots, right?
5 years, 9 months ago (2015-03-06 20:49:29 UTC) #3
rmistry
LGTM
5 years, 9 months ago (2015-03-09 12:36:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986583004/20001
5 years, 9 months ago (2015-03-09 13:34:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986583004/20001
5 years, 9 months ago (2015-03-09 13:37:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986583004/20001
5 years, 9 months ago (2015-03-09 13:54:01 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:59:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/13e51f91ef39597430de8f318263f105ce14ba40

Powered by Google App Engine
This is Rietveld 408576698