base: Remove operator& from ScopedAuthorizationRef.

base/mac/authorization_util.mm

Index: base/mac/authorization_util.mm
diff --git a/base/mac/authorization_util.mm b/base/mac/authorization_util.mm
index 003c26d65c7b5b050ee94c3ab7618c615b3c372c..1dfd5a019f22f4d40566f78224ea2373c69f7fb8 100644
--- a/base/mac/authorization_util.mm
+++ b/base/mac/authorization_util.mm
@@ -28,10 +28,9 @@ AuthorizationRef GetAuthorizationRightsWithPrompt(
     AuthorizationFlags extraFlags) {
   // Create an empty AuthorizationRef.
   ScopedAuthorizationRef authorization;
-  OSStatus status = AuthorizationCreate(NULL,
-                                        kAuthorizationEmptyEnvironment,
+  OSStatus status = AuthorizationCreate(NULL, kAuthorizationEmptyEnvironment,
                                         kAuthorizationFlagDefaults,
-                                        &authorization);
+                                        authorization.get_pointer());

[danakj, 2015/03/06 23:32:38]

Please double check for me that get_pointer() is actually what we want here..

[Nico, 2015/03/07 00:03:13]

Yup, this is correct. Relevant -ast-dump output:

    | | |     `-CXXOperatorCallExpr 0x107ec3950 <line:34:41, col:42>
'AuthorizationRef *'
    | | |       |-ImplicitCastExpr 0x107ec3938 <col:41> 'AuthorizationRef
*(*)(void)' <FunctionToPointerDecay>
    | | |       | `-DeclRefExpr 0x107ec38b0 <col:41> 'AuthorizationRef *(void)'
lvalue CXXMethod 0x107e9dc00 'operator&' 'AuthorizationRef *(void)'
    | | |       `-DeclRefExpr 0x107ec3888 <col:42> 'class
base::mac::ScopedAuthorizationRef' lvalue Var 0x107ec36a0 'authorization' 'class
base::mac::ScopedAuthorizationRef'

   if (status != errAuthorizationSuccess) {
     OSSTATUS_LOG(ERROR, status) << "AuthorizationCreate";
     return NULL;