base: Remove operator& from ScopedAuthorizationRef.

base: Remove operator& from ScopedAuthorizationRef.

The operator& is dangerous and makes it unclear what you are doing.
Replace it with a get_pointer() method.

R=Nico
TBR=garykac@chromium.org
BUG=464816
Committed: https://crrev.com/845755856c54aabac7022ee373618468b92f2e61
Cr-Commit-Position: refs/heads/master@{#319565}

Committed: https://crrev.com/318afca092085cc5375a6b5547383d78baee3778
Cr-Commit-Position: refs/heads/master@{#319663}

[danakj, 2015-03-06 23:32:39]

https://codereview.chromium.org/986563003/diff/1/base/mac/authorization_util.mm
File base/mac/authorization_util.mm (right):

https://codereview.chromium.org/986563003/diff/1/base/mac/authorization_util....
base/mac/authorization_util.mm:33: authorization.get_pointer());
Please double check for me that get_pointer() is actually what we want here..

[Nico, 2015-03-07 00:03:13]

lgtm

https://codereview.chromium.org/986563003/diff/1/base/mac/authorization_util.mm
File base/mac/authorization_util.mm (right):

https://codereview.chromium.org/986563003/diff/1/base/mac/authorization_util....
base/mac/authorization_util.mm:33: authorization.get_pointer());
On 2015/03/06 23:32:38, danakj wrote:
> Please double check for me that get_pointer() is actually what we want here..

Yup, this is correct. Relevant -ast-dump output:

    | | |     `-CXXOperatorCallExpr 0x107ec3950 <line:34:41, col:42>
'AuthorizationRef *'
    | | |       |-ImplicitCastExpr 0x107ec3938 <col:41> 'AuthorizationRef
*(*)(void)' <FunctionToPointerDecay>
    | | |       | `-DeclRefExpr 0x107ec38b0 <col:41> 'AuthorizationRef *(void)'
lvalue CXXMethod 0x107e9dc00 'operator&' 'AuthorizationRef *(void)'
    | | |       `-DeclRefExpr 0x107ec3888 <col:42> 'class
base::mac::ScopedAuthorizationRef' lvalue Var 0x107ec36a0 'authorization' 'class
base::mac::ScopedAuthorizationRef'

[danakj, 2015-03-07 00:03:45]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-03-07 00:04:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986563003/1

[commit-bot: I haz the power, 2015-03-07 02:04:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 02:04:01]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[danakj, 2015-03-07 17:14:08]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2015-03-07 17:16:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986563003/1

[commit-bot: I haz the power, 2015-03-07 23:02:24]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-07 23:03:34]

Patchset 1 (id:??) landed as
https://crrev.com/845755856c54aabac7022ee373618468b92f2e61
Cr-Commit-Position: refs/heads/master@{#319565}

[hichris123, 2015-03-08 00:16:32]

On 2015/03/07 23:03:34, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/845755856c54aabac7022ee373618468b92f2e61
> Cr-Commit-Position: refs/heads/master@{#319565}

Hrm, looks like this CL is causing the Mac compile errors (even though the
tryjobs passed), see for example
http://build.chromium.org/p/chromium/builders/Mac/builds/34454/steps/compile/....

no known conversion from 'base::mac::ScopedAuthorizationRef *' to
'AuthorizationRef *' (aka 'const AuthorizationOpaqueRef **') for 4th argument

[Avi (use Gerrit), 2015-03-08 02:35:00]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/988113002/ by avi@chromium.org.

The reason for reverting is: Breaks the official Mac bot:

../../remoting/host/installer/mac/uninstaller/remoting_uninstaller.mm:155:21:error:
no matching function for call to 'AuthorizationCreate'
  OSStatus status = AuthorizationCreate(nullptr, kAuthorizationEmptyEnvironment,
                    ^~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Security.framework/Headers/Authorization.h:253:10:
note: candidate function not viable: no known conversion from
'base::mac::ScopedAuthorizationRef *' to 'AuthorizationRef *' (aka 'const
AuthorizationOpaqueRef **') for 4th argument
OSStatus AuthorizationCreate(const AuthorizationRights *rights,
.

[Avi (use Gerrit), 2015-03-08 02:35:44]

Alas, there are no trybots for the official build.

[danakj, 2015-03-09 16:30:07]

danakj@chromium.org changed reviewers:
+ garykac@chromium.org

[danakj, 2015-03-09 16:30:10]

The CQ bit was checked by danakj@chromium.org

[danakj, 2015-03-09 16:30:10]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/986563003/#ps20001 (title:
"authorization: for-official-build")

[danakj, 2015-03-09 16:30:20]

Fixed the official build error.

[commit-bot: I haz the power, 2015-03-09 16:30:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986563003/20001

[Nico, 2015-03-09 16:31:20]

still lgtm

not sure if official builds with -k 0 (probably not?), so this might not be the
only official build error

[danakj, 2015-03-09 16:34:55]

On Mon, Mar 9, 2015 at 9:31 AM, <thakis@chromium.org> wrote:

> still lgtm
>
> not sure if official builds with -k 0 (probably not?), so this might not
> be the
> only official build error
>

I'm hopeful from grepping :)

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2015-03-09 16:35:24]

good enough :-)

On Mon, Mar 9, 2015 at 9:34 AM, Dana Jansens <danakj@chromium.org> wrote:

> On Mon, Mar 9, 2015 at 9:31 AM, <thakis@chromium.org> wrote:
>
>> still lgtm
>>
>> not sure if official builds with -k 0 (probably not?), so this might not
>> be the
>> only official build error
>>
>
> I'm hopeful from grepping :)
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[garykac, 2015-03-09 16:41:22]

lgtm

[commit-bot: I haz the power, 2015-03-09 17:18:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-09 17:19:17]

Patchset 2 (id:??) landed as
https://crrev.com/318afca092085cc5375a6b5547383d78baee3778
Cr-Commit-Position: refs/heads/master@{#319663}