Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(266)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: go/src/infra/gae/libs/memlock/memlock.infra_testing
Issue
986553002
:
A simple memcache lock for appengine. (Closed)
Base URL: https://chromium.googlesource.com/infra/infra.git@meta
Patch Set: Add memlock tests!
Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
go/src/infra/gae/libs/memlock/doc.go
go/src/infra/gae/libs/memlock/memlock.go
go/src/infra/gae/libs/memlock/memlock.goconvey
go/src/infra/gae/libs/memlock/memlock.infra_testing
go/src/infra/gae/libs/memlock/memlock_test.go
View unified diff
|
Download patch
« go/src/infra/gae/libs/memlock/memlock.go
('K') |
« go/src/infra/gae/libs/memlock/memlock.goconvey
('k') |
go/src/infra/gae/libs/memlock/memlock_test.go »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"expected_coverage_min": 98.3,
3
"expected_coverage_max": 98.5,
4
"build_tags": ["appengine"]
5
}
OLD
NEW
« go/src/infra/gae/libs/memlock/memlock.go
('K') |
« go/src/infra/gae/libs/memlock/memlock.goconvey
('k') |
go/src/infra/gae/libs/memlock/memlock_test.go »
('j') |
no next file with comments »
Issue 986553002: A simple memcache lock for appengine. (Closed)
Created 5 years, 9 months ago by iannucci
Modified 5 years, 6 months ago
Reviewers: Vadim Sh., M-A Ruel
Base URL: https://chromium.googlesource.com/infra/infra.git@meta
Comments: 55
This is Rietveld
408576698
Chromium Code Reviews
Issue 986553002:
A simple memcache lock for appengine. (Closed)
Base URL: https://chromium.googlesource.com/infra/infra.git@meta