[SyncFS] Update tracker on upload

[SyncFS] Update tracker on upload

BUG=240165
NOTRY=true
R=kinuko@chromium.org, nhiroki@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238319

[tzik, 2013-12-02 09:00:16]

PTL

[kinuko, 2013-12-02 09:05:39]

looks good, one comment for naming

https://codereview.chromium.org/98653002/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc
(right):

https://codereview.chromium.org/98653002/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc:397:
base::Bind(&LocalToRemoteSyncer::DidUpdateMetadataForUpload,
We have DidUpdateDatabaseForUpload for UploadNewFile case, can we name these
better?

[nhiroki, 2013-12-02 09:22:36]

lgtm

[kinuko, 2013-12-02 09:40:29]

https://codereview.chromium.org/98653002/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc
(right):

https://codereview.chromium.org/98653002/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc:414:
NOTREACHED();
Hmm, I hit here in my local testing.

[tzik, 2013-12-02 15:30:49]

https://codereview.chromium.org/98653002/diff/1/chrome/browser/sync_file_syst...
File chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc
(right):

https://codereview.chromium.org/98653002/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc:397:
base::Bind(&LocalToRemoteSyncer::DidUpdateMetadataForUpload,
On 2013/12/02 09:05:39, kinuko wrote:
> We have DidUpdateDatabaseForUpload for UploadNewFile case, can we name these
> better?

Renamed.
Do DidUpdateDatabaseForUpload{NewFile,ExistingFile} work?

https://codereview.chromium.org/98653002/diff/1/chrome/browser/sync_file_syst...
chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc:414:
NOTREACHED();
On 2013/12/02 09:40:30, kinuko wrote:
> Hmm, I hit here in my local testing.

...
That's broken, reversed.
Fixed! Thanks!

[kinuko, 2013-12-03 02:03:03]

lgtm

[commit-bot: I haz the power, 2013-12-03 03:24:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/98653002/20001

[commit-bot: I haz the power, 2013-12-03 04:18:00]

Retried try job too often on linux_rel for step(s) browser_tests, check_deps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-12-03 04:20:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/98653002/20001

[tzik, 2013-12-03 08:01:13]

Committed patchset #2 manually as r238319 (presubmit successful).