Revert of Correctly handle tab navigation in the app list.

Revert of Correctly handle tab navigation in the app list. (patchset #3 id:40001 of https://codereview.chromium.org/960133005/)

Reason for revert:
The new test appears to be flaky, unfortunately:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=CustomLauncherPageBrowserTest.LauncherPageFocusTraversal&testType=browser_tests



Original issue's description:
> Correctly handle tab navigation in the app list.
> 
> This CL causes the app list tab navigation to correctly cycle to and from
> the custom launcher page. This has been fixed by adding a SearchBoxFocusHost
> which directs the focus search to the search box.
> 
> BUG=462079
> 
> Committed: https://crrev.com/a4e2242b75647b641e6d2190b01cde7c9c5233c8
> Cr-Commit-Position: refs/heads/master@{#318814}

TBR=mgiuca@chromium.org,benwells@chromium.org,calamity@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=462079

[Dirk Pranke, 2015-03-06 00:04:24]

Created Revert of Correctly handle tab navigation in the app list.

[commit-bot: I haz the power, 2015-03-06 00:05:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/986513002/1

[commit-bot: I haz the power, 2015-03-06 00:06:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-06 00:06:07]

Failed to apply patch for
chrome/browser/apps/custom_launcher_page_browsertest_views.cc:
While running git apply --index -3 -p1;
  error: patch failed:
chrome/browser/apps/custom_launcher_page_browsertest_views.cc:386
  Falling back to three-way merge...
  Applied patch to
'chrome/browser/apps/custom_launcher_page_browsertest_views.cc' with conflicts.
  U chrome/browser/apps/custom_launcher_page_browsertest_views.cc

Patch:       chrome/browser/apps/custom_launcher_page_browsertest_views.cc
Index: chrome/browser/apps/custom_launcher_page_browsertest_views.cc
diff --git a/chrome/browser/apps/custom_launcher_page_browsertest_views.cc
b/chrome/browser/apps/custom_launcher_page_browsertest_views.cc
index
561280b74e2efc66ee70284e35214ffd7b76ae2b..8f4fb35a5e60229607c314680c7920f74d81dc80
100644
--- a/chrome/browser/apps/custom_launcher_page_browsertest_views.cc
+++ b/chrome/browser/apps/custom_launcher_page_browsertest_views.cc
@@ -20,11 +20,8 @@
 #include "ui/app_list/views/app_list_main_view.h"
 #include "ui/app_list/views/app_list_view.h"
 #include "ui/app_list/views/contents_view.h"
-#include "ui/app_list/views/search_box_view.h"
 #include "ui/events/test/event_generator.h"
-#include "ui/views/controls/textfield/textfield.h"
 #include "ui/views/controls/webview/webview.h"
-#include "ui/views/focus/focus_manager.h"
 
 namespace {
 
@@ -386,43 +383,3 @@
   EXPECT_TRUE(model->custom_launcher_page_enabled());
   EXPECT_TRUE(custom_page_view->visible());
 }
-
-IN_PROC_BROWSER_TEST_F(CustomLauncherPageBrowserTest,
-                       LauncherPageFocusTraversal) {
-  LoadAndLaunchPlatformApp(kCustomLauncherPagePath, "Launched");
-  app_list::AppListView* app_list_view = GetAppListView();
-  app_list::ContentsView* contents_view =
-      app_list_view->app_list_main_view()->contents_view();
-  app_list::SearchBoxView* search_box_view =
-      app_list_view->app_list_main_view()->search_box_view();
-
-  ASSERT_TRUE(
-      contents_view->IsStateActive(app_list::AppListModel::STATE_START));
-  EXPECT_EQ(app_list_view->GetFocusManager()->GetFocusedView(),
-            search_box_view->search_box());
-
-  {
-    ExtensionTestMessageListener listener("onPageProgressAt1", false);
-    contents_view->SetActivePage(contents_view->GetPageIndexForState(
-        app_list::AppListModel::STATE_CUSTOM_LAUNCHER_PAGE));
-    listener.WaitUntilSatisfied();
-    EXPECT_TRUE(contents_view->IsStateActive(
-        app_list::AppListModel::STATE_CUSTOM_LAUNCHER_PAGE));
-    EXPECT_EQ(app_list_view->GetFocusManager()->GetFocusedView(),
-              search_box_view->search_box());
-  }
-  {
-    ExtensionTestMessageListener listener("textfieldFocused", false);
-    app_list_view->GetFocusManager()->AdvanceFocus(false);
-    listener.WaitUntilSatisfied();
-    EXPECT_NE(app_list_view->GetFocusManager()->GetFocusedView(),
-              search_box_view->search_box());
-  }
-  {
-    ExtensionTestMessageListener listener("textfieldBlurred", false);
-    app_list_view->GetFocusManager()->AdvanceFocus(false);
-    listener.WaitUntilSatisfied();
-    EXPECT_EQ(app_list_view->GetFocusManager()->GetFocusedView(),
-              search_box_view->search_box());
-  }
-}

[commit-bot: I haz the power, 2015-03-06 00:06:42]

The CQ bit was unchecked by commit-bot@chromium.org

[Matt Giuca, 2015-03-06 00:09:52]

not lgtm

It seems that you are reverting this because of a flaky test. The original CL
has already been merged into the M42 branch so this could create a bit of a
headache. I'd prefer that we just look into the flaky test (disable it if
necessary).

[Matt Giuca, 2015-03-06 00:13:58]

It looks like the test was already disabled on ChromeOS:
https://codereview.chromium.org/973793003
(which is probably why your patch fails).

but you are saying it's failing on all platforms? In that case I'll disable it
across all platforms as well.

[Dirk Pranke, 2015-03-06 00:23:44]

On 2015/03/06 00:13:58, Matt Giuca wrote:
> It looks like the test was already disabled on ChromeOS:
> https://codereview.chromium.org/973793003
> (which is probably why your patch fails).
> 
> but you are saying it's failing on all platforms? In that case I'll disable it
> across all platforms as well.

Yes, we're seeing flakes on Linux and Windows as well.

Disabling the test is fine by me if you think the underlying code change is
okay, and the problem is just w/ the test.

[Dirk Pranke, 2015-03-06 00:24:10]

I'll assume you'll disable it on the other platforms. Thanks!