Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 986503004: Some cleanup in extensions/renderer/dispatcher.cc . (Closed)

Created:
5 years, 9 months ago by paulmeyer
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Some cleanup in the extensions renderer dispatcher. Moved the requiring of guestview modules into a seperate helper function, including that of extensionOptions, which was previously left in the chrome renderer dispatcher. BUG=466215 Committed: https://crrev.com/ab77a103bb1337af53d1179676d226ebd5ae9480 Cr-Commit-Position: refs/heads/master@{#320229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -35 lines) Patch
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/dispatcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +44 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paulmeyer
+kalman@
5 years, 9 months ago (2015-03-11 18:43:30 UTC) #2
not at google - send to devlin
sorry didn't notice this one. lgtm.
5 years, 9 months ago (2015-03-11 22:50:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986503004/1
5 years, 9 months ago (2015-03-12 02:51:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 03:51:51 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 03:52:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab77a103bb1337af53d1179676d226ebd5ae9480
Cr-Commit-Position: refs/heads/master@{#320229}

Powered by Google App Engine
This is Rietveld 408576698