Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: components/metrics/leak_detector/leak_analyzer.h

Issue 986503002: components/metrics: Add runtime memory leak detector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix portability issues for sizes and addresses Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/leak_detector/leak_analyzer.h
diff --git a/components/metrics/leak_detector/leak_analyzer.h b/components/metrics/leak_detector/leak_analyzer.h
new file mode 100644
index 0000000000000000000000000000000000000000..f9226680ec3ea40d2a5295c3e224c160ca0ed40f
--- /dev/null
+++ b/components/metrics/leak_detector/leak_analyzer.h
@@ -0,0 +1,118 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_METRICS_LEAK_DETECTOR_LEAK_ANALYZER_H_
+#define COMPONENTS_METRICS_LEAK_DETECTOR_LEAK_ANALYZER_H_
+
+#include <map>
+#include <vector>
+
+#include "components/metrics/leak_detector/leak_detector_value_type.h"
+#include "components/metrics/leak_detector/ranked_list.h"
+#include <gperftools/custom_allocator.h>
+
+// This class looks for possible leak patterns in allocation data over time.
+
+namespace leak_detector {
+
+class LeakAnalyzer {
+ public:
+ using ValueType = LeakDetectorValueType;
+
+ // Interface for printing strings for various value types.
+ class StringPrint {
+ public:
jar (doing other things) 2015/08/15 03:29:01 nit: declare a virtual destructor.
Simon Que 2015/08/15 23:28:31 Done.
+ // Gets the string representation of a value. Returns the string stored in
+ // |buffer_|. The contents of |buffer_| will change if this is called again
+ // with different inputs.
+ virtual const char* ValueToString(const ValueType& value,
+ bool spacing_on) = 0;
+
+ // Gets the word that describes the value type.
+ virtual const char* ValueTypeName(bool is_plural) = 0;
+
+ protected:
+ // Buffer for returning the string representation of a value.
+ static const int kStringPrintBufferSize = 1024;
+ char buffer_[kStringPrintBufferSize];
+ };
jar (doing other things) 2015/08/15 03:29:01 Are you buying anything by using this class? Do y
Simon Que 2015/08/15 23:28:31 There are two derived classes. Although I could mo
Simon Que 2015/08/18 22:34:04 Done.
+
+ template <typename Type>
+ using Allocator = STL_Allocator<Type, CustomAllocator>;
+
+ LeakAnalyzer(uint32_t ranking_size,
+ uint32_t num_suspicions_threshold,
+ StringPrint* string_print)
+ : ranking_size_(ranking_size),
+ score_increase_(1 << num_suspicions_threshold),
+ score_threshold_((1 << num_suspicions_threshold) * 2 - 1),
+ ranked_entries_(ranking_size),
+ prev_ranked_entries_(ranking_size),
+ string_print_(string_print) {
+ suspected_leaks_.reserve(ranking_size);
+ }
+
+ ~LeakAnalyzer() {}
+
+ // Take in a list of allocations, sorted by count.
+ void AddSample(const RankedList& ranked_list);
+
+ // Used to report suspected leaks.
+ const std::vector<ValueType, Allocator<ValueType>>& suspected_leaks() const {
+ return suspected_leaks_;
+ }
+
+ // Log the leak detector's top sizes and suspected sizes. |buffer| is a char
+ // buffer of size |buffer_size| that can eventually be logged.
+ int Dump(char* buffer, const int buffer_size) const;
+
+ private:
+ using RankedEntry = RankedList::Entry;
+
+ // Analyze a list of allocation count deltas from the previous iteration. If
+ // anything looks like a possible leak, update the suspicion scores.
+ void AnalyzeDeltas(const RankedList& ranked_deltas);
+
+ // Returns the count for the given value from the previous analysis in
+ // |count|. Returns true if the given value was present in the previous
+ // analysis, or false if not.
+ bool GetPreviousCountForValue(const ValueType& value, uint32_t* count) const;
+
+ // Look for the top |ranking_size_| entries when analyzing leaks.
+ const uint32_t ranking_size_;
+
+ // Each time an entry is suspected as a possible leak, increase its suspicion
+ // score by this much.
+ const uint32_t score_increase_;
+
+ // Report suspected leaks when the suspicion score reaches this value.
+ const uint32_t score_threshold_;
+
+ // A mapping of allocation values to suspicion score. All allocations in this
+ // container are suspected leaks. The score can increase or decrease over
+ // time. Once the score reaches |score_threshold_|, the entry is reported as
+ // a suspected leak in |suspected_leaks_|.
+ std::map<ValueType,
+ uint32_t,
+ std::less<ValueType>,
+ Allocator<std::pair<ValueType, uint32_t>>> suspected_histogram_;
+
+ // Array of allocated values that passed the suspicion threshold and are being
+ // reported.
+ std::vector<ValueType, Allocator<ValueType>> suspected_leaks_;
+
+ // The most recent allocation entries, since the last call to AddSample().
+ RankedList ranked_entries_;
+ // The previous allocation entries, from before the last call to AddSample().
+ RankedList prev_ranked_entries_;
+
+ // For logging.
+ StringPrint* string_print_;
+
+ DISALLOW_COPY_AND_ASSIGN(LeakAnalyzer);
+};
+
+} // namespace leak_detector
+
+#endif // COMPONENTS_METRICS_LEAK_DETECTOR_LEAK_ANALYZER_H_

Powered by Google App Engine
This is Rietveld 408576698