Source/platform/fonts/shaping/SimpleShaper.h - Issue 986493002: Simplify text emphasis painting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/SimpleShaper.h

Issue 986493002: Simplify text emphasis painting (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/shaping/SimpleShaper.h

diff --git a/Source/platform/fonts/shaping/SimpleShaper.h b/Source/platform/fonts/shaping/SimpleShaper.h

index 2c50d6359f8c216e4b5a54e0f35e5e1790f67fca..b3297d5b03320d2bf58e1532751a3893e14ca332 100644

--- a/Source/platform/fonts/shaping/SimpleShaper.h

+++ b/Source/platform/fonts/shaping/SimpleShaper.h

@@ -42,7 +42,8 @@ struct GlyphData;

struct PLATFORM_EXPORT SimpleShaper : public Shaper {

WTF_MAKE_FAST_ALLOCATED;

public:

- SimpleShaper(const Font*, const TextRun&, HashSet<const SimpleFontData*>* fallbackFonts = 0, FloatRect* = 0, bool forTextEmphasis = false);

+ SimpleShaper(const Font*, const TextRun&, const GlyphData* emphasisData = nullptr,

+ HashSet<const SimpleFontData*>* fallbackFonts = nullptr, FloatRect* = nullptr);

unsigned advance(unsigned to, GlyphBuffer* = 0);

bool advanceOneCharacter(float& width);