Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: Source/platform/fonts/Font.h

Issue 986493002: Simplify text emphasis painting (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/platform/fonts/Font.cpp » ('j') | Source/platform/fonts/shaping/SimpleShaper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/Font.h
diff --git a/Source/platform/fonts/Font.h b/Source/platform/fonts/Font.h
index 73144797476e6e577f82d66849495275a844f78b..cc22b1c3100f52e07a5971f64a38278d1d67efb6 100644
--- a/Source/platform/fonts/Font.h
+++ b/Source/platform/fonts/Font.h
@@ -138,7 +138,7 @@ private:
enum ForTextEmphasisOrNot { NotForTextEmphasis, ForTextEmphasis };
// Returns the total advance.
- float buildGlyphBuffer(const TextRunPaintInfo&, GlyphBuffer&, ForTextEmphasisOrNot = NotForTextEmphasis) const;
+ float buildGlyphBuffer(const TextRunPaintInfo&, GlyphBuffer&, const GlyphData* = nullptr) const;
jbroman 2015/03/07 18:50:25 Please include a name for this argument; it's not
f(malita) 2015/03/09 15:04:55 Done.
PassTextBlobPtr buildTextBlob(const GlyphBuffer&) const;
SkPaint textFillPaint(GraphicsContext*, const SimpleFontData*) const;
SkPaint textStrokePaint(GraphicsContext*, const SimpleFontData*, bool isFilling) const;
@@ -151,7 +151,6 @@ private:
void drawGlyphs(GraphicsContext*, const SimpleFontData*, const GlyphBuffer&, unsigned from, unsigned numGlyphs, const FloatPoint&, const FloatRect& textRect) const;
void drawTextBlob(GraphicsContext*, const SkTextBlob*, const SkPoint& origin) const;
void drawGlyphBuffer(GraphicsContext*, const TextRunPaintInfo&, const GlyphBuffer&, const FloatPoint&) const;
- void drawEmphasisMarks(GraphicsContext*, const TextRunPaintInfo&, const GlyphBuffer&, const AtomicString&, const FloatPoint&) const;
float floatWidthForSimpleText(const TextRun&, HashSet<const SimpleFontData*>* fallbackFonts = 0, IntRectOutsets* glyphBounds = 0) const;
int offsetForPositionForSimpleText(const TextRun&, float position, bool includePartialGlyphs) const;
FloatRect selectionRectForSimpleText(const TextRun&, const FloatPoint&, int h, int from, int to, bool accountForGlyphBounds) const;
« no previous file with comments | « no previous file | Source/platform/fonts/Font.cpp » ('j') | Source/platform/fonts/shaping/SimpleShaper.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698