Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 986463005: Add MoveOnlyTypeForCPP03 to UniquePersistent for compatibility with Chromium. (Closed)

Created:
5 years, 9 months ago by not at google - send to devlin
Modified:
5 years, 9 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://github.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add MoveOnlyTypeForCPP03 to UniquePersistent for compatibility with Chromium. R=dcarney@chromium.org Committed: https://crrev.com/c23035cdd0b47afe3717c1a25f13ca075af0c1a2 Cr-Commit-Position: refs/heads/master@{#27049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M include/v8.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
not at google - send to devlin
I'm from the Chromium Extensions team and would like to replace our home-grown use of ...
5 years, 9 months ago (2015-03-06 01:57:00 UTC) #1
not at google - send to devlin
I.e. this makes it so you can do: v8::UniquePersistent p = ...; base::Bind(&MyFunction, base::Passed(&p));
5 years, 9 months ago (2015-03-06 01:57:43 UTC) #2
arv (Not doing code reviews)
I have no idea what this is but I assigned some reviewers that should know ...
5 years, 9 months ago (2015-03-06 09:14:17 UTC) #5
dcarney
lgtm
5 years, 9 months ago (2015-03-06 09:16:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986463005/1
5 years, 9 months ago (2015-03-06 15:21:36 UTC) #8
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
5 years, 9 months ago (2015-03-06 15:21:38 UTC) #10
not at google - send to devlin
> _not_ a full super star committer. That line gets on my nerves.
5 years, 9 months ago (2015-03-06 15:22:49 UTC) #11
arv (Not doing code reviews)
On 2015/03/06 15:22:49, kalman wrote: > > _not_ a full super star committer. > > ...
5 years, 9 months ago (2015-03-06 16:11:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986463005/1
5 years, 9 months ago (2015-03-06 16:12:27 UTC) #15
not at google - send to devlin
On 2015/03/06 16:11:16, arv wrote: > On 2015/03/06 15:22:49, kalman wrote: > > > _not_ ...
5 years, 9 months ago (2015-03-06 16:15:56 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 16:39:08 UTC) #17
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 16:39:25 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c23035cdd0b47afe3717c1a25f13ca075af0c1a2
Cr-Commit-Position: refs/heads/master@{#27049}

Powered by Google App Engine
This is Rietveld 408576698