Issue 986463004: Sync: Added extra validation to FindLocalIdToUpdate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 986463004: Sync: Added extra validation to FindLocalIdToUpdate. (Closed)

Created:
5 years, 9 months ago by stanisc

Modified:
5 years, 9 months ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Sync: Added extra validation to FindLocalIdToUpdate. This is an extra check in FindLocalIdToUpdate which should help to narrow down the cause of the crash in syncer::syncable::ChangeEntryIDAndUpdateChildren and gather more information on the state of the directory leading to the crash. BUG=362467 Committed: https://crrev.com/4b27fc71cdfbb6105a9caf215b6f8aa968a729ab Cr-Commit-Position: refs/heads/master@{#319802}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -0 lines)			Patch
	M	sync/engine/syncer_util.cc	View		5 chunks	+48 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/986463004/1

5 years, 9 months ago (2015-03-10 00:09:10 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-10 01:04:58 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4b27fc71cdfbb6105a9caf215b6f8aa968a729ab
Cr-Commit-Position: refs/heads/master@{#319802}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages