Issue 986463003: fix typo in _syncEvent; make it possible for a component to entirely change the class of its render…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 986463003: fix typo in _syncEvent; make it possible for a component to entirely change the class of its render… (Closed)

Created:
5 years, 9 months ago by Hixie

Modified:
5 years, 9 months ago

Reviewers:
rafaelw, abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

fix typo in _syncEvent; make it possible for a component to entirely change the class of its rendering's component R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2644c4551ce3c6a8b9979d99d333a90ad7552606

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
	M	sky/framework/fn.dart	View		4 chunks	+10 lines, -12 lines	0 comments	Download

Total messages: 5 (1 generated)

abarth-chromium

@raf: Is there something we need to be careful about when relaxing this restriction?

5 years, 9 months ago (2015-03-06 00:05:42 UTC) #2

Hixie

Committed patchset #1 (id:1) manually as 2644c4551ce3c6a8b9979d99d333a90ad7552606 (presubmit successful).

5 years, 9 months ago (2015-03-06 00:06:36 UTC) #4

rafaelw

5 years, 9 months ago (2015-03-06 21:28:59 UTC) #5

Message was sent while issue was closed.

yeah, there's a piece missing here which is cleaning up the old DOM. Fixed in
this patch:

https://codereview.chromium.org/984983004