Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 986463003: fix typo in _syncEvent; make it possible for a component to entirely change the class of its render… (Closed)

Created:
5 years, 9 months ago by Hixie
Modified:
5 years, 9 months ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

fix typo in _syncEvent; make it possible for a component to entirely change the class of its rendering's component R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2644c4551ce3c6a8b9979d99d333a90ad7552606

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M sky/framework/fn.dart View 4 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
@raf: Is there something we need to be careful about when relaxing this restriction?
5 years, 9 months ago (2015-03-06 00:05:42 UTC) #2
abarth-chromium
LGTM -- ideally raf would review as well
5 years, 9 months ago (2015-03-06 00:06:12 UTC) #3
Hixie
Committed patchset #1 (id:1) manually as 2644c4551ce3c6a8b9979d99d333a90ad7552606 (presubmit successful).
5 years, 9 months ago (2015-03-06 00:06:36 UTC) #4
rafaelw
5 years, 9 months ago (2015-03-06 21:28:59 UTC) #5
Message was sent while issue was closed.
yeah, there's a piece missing here which is cleaning up the old DOM. Fixed in
this patch:

https://codereview.chromium.org/984983004

Powered by Google App Engine
This is Rietveld 408576698