Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp

Issue 986453002: Additional clean ups on errors in bitcode parsing. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Patch Set: Fix comment. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/Bitcode/NaCl/Analysis/NaClObjDumpStream.cpp ('k') | lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp
diff --git a/lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp b/lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp
index 3dc9a17bd755a7a868527fe1342742320e8ebe53..0c9ef637072644ce6e971690268bbc63852230ac 100644
--- a/lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp
+++ b/lib/Bitcode/NaCl/Reader/NaClBitcodeParser.cpp
@@ -86,19 +86,15 @@ NaClBitcodeParser::~NaClBitcodeParser() {
}
}
-bool NaClBitcodeParser::ErrorAt(uint64_t BitPosition,
- const std::string &Message) {
- *ErrStream << "Error(" << NaClBitstreamReader::getBitAddress(BitPosition, 1)
- << "): " << Message << "\n";
+bool NaClBitcodeParser::ErrorAt(
+ naclbitc::ErrorLevel Level, uint64_t BitPosition,
+ const std::string &Message) {
+ naclbitc::ErrorAt(*ErrStream, Level, BitPosition) << Message << "\n";
+ if (Level == naclbitc::Fatal)
+ report_fatal_error("Unable to continue");
return true;
}
-void NaClBitcodeParser::FatalAt(uint64_t BitPosition,
- const std::string &Message) {
- ErrorAt(BitPosition, Message);
- report_fatal_error("Unable to continue");
-}
-
bool NaClBitcodeParser::Parse() {
Record.ReadEntry();
« no previous file with comments | « lib/Bitcode/NaCl/Analysis/NaClObjDumpStream.cpp ('k') | lib/Bitcode/NaCl/Reader/NaClBitcodeReader.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698