Additional clean ups on errors in bitcode parsing.

include/llvm/Bitcode/NaCl/NaClBitcodeParser.h

 //===- NaClBitcodeParser.h -----------------------------------*- C++ -*-===//
 //     Low-level bitcode driver to parse PNaCl bitcode files.
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 //
@@ skipping 470 matching lines @@
     NaClBitcodeParser Parser(BlockID, this);
     return Parser.ParseThisBlock();
   }
 
   // Changes the stream to print errors to, and returns the old error stream.
   // There are two use cases:
   // 1) To change (from the default errs()) inside the constructor of the
   //    derived class. In this context, it will be used for all error
   //    messages for the derived class.
   // 2) Temporarily modify it for a single error message. In this context,
-  //    the method Error() is overridden in the derived class, and
-  //    calls this method twice. Once before calling base method Error(),
-  //    and followed by a second call to restore the default error stream.
+  //    the method ErrorAt(ErrorLevel, Bit, Message) is overridden in
+  //    the derived class, and calls this method twice. Once before
+  //    calling base method Error(), and followed by a second call to

[jvoung (off chromium), 2015/03/09 18:50:23]

Another mention of "base method Error()".

Probably don't need to be so specific about exactly where this is used. At a
high level, this is either (1) to make all error messages "always" go to the
given stream, or to (2) to temporarily make a single error message go to a
different stream (which requires returning the old stream so it can be
restored).

[Karl, 2015/03/09 19:49:25]

Done.

+  //    restore the default error stream.
   raw_ostream &setErrStream(raw_ostream &Stream) {
     raw_ostream &OldErrStream = *ErrStream;
     ErrStream = &Stream;
     return OldErrStream;
   }
 
   // Called when an error occurs. BitPosition is the bit position the
   // error was found, and Message is the error to report. Always
-  // returns true (the error return value of Parse).
-  virtual bool ErrorAt(uint64_t BitPosition, const std::string &Message);
+  // returns true (the error return value of Parse). Level is
+  // the severity of the error.
+  virtual bool ErrorAt(naclbitc::ErrorLevel Level, uint64_t BitPosition,
+                       const std::string &Message);
+
+  bool ErrorAt(uint64_t BitPosition, const std::string &Message) {
+    return ErrorAt(naclbitc::Error, BitPosition, Message);
+  }
 
   // Called when an error occurs. Message is the error to
   // report. Always returns true (the error return value of Parse).
   bool Error(const std::string &Message) {
     return ErrorAt(Record.GetStartBit(), Message);
   }
 
   // Called when a fatal error occurs. BitPosition is the bit position
   // the error was found, and Message is the error to report. Does not
   // return.
   LLVM_ATTRIBUTE_NORETURN
-  virtual void FatalAt(uint64_t BitPosition, const std::string &Message);
+  void FatalAt(uint64_t BitPosition, const std::string &Message) {
+    ErrorAt(naclbitc::Fatal, BitPosition, Message);
+    llvm_unreachable("Fatal errors should not return");
+  }
 
   // Called when a fatal error occurs. Message is the error to
   // report. Does not return.
   LLVM_ATTRIBUTE_NORETURN
   void Fatal(const std::string &Message) {
     FatalAt(Record.GetStartBit(), Message);
   }
 
   // Generates fatal generic error message.
   LLVM_ATTRIBUTE_NORETURN
@@ skipping 112 matching lines @@
   bool ParseBlockInternal();
 
   void operator=(const NaClBitcodeParser &Parser) LLVM_DELETED_FUNCTION;
   NaClBitcodeParser(const NaClBitcodeParser &Parser) LLVM_DELETED_FUNCTION;
 
 };
 
 }  // namespace llvm
 
 #endif