Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: ui/gl/gl_surface.cc

Issue 98643013: Take GL version and extensions correctly into account when binding functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Clarify code in generate_bindings.py according to feedback Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_surface.cc
diff --git a/ui/gl/gl_surface.cc b/ui/gl/gl_surface.cc
index 55bc1b86090353d931d211aaf26b0c530e183825..0a2e08914b1633a25d84ab3b78096b9eaa7504aa 100644
--- a/ui/gl/gl_surface.cc
+++ b/ui/gl/gl_surface.cc
@@ -13,7 +13,6 @@
#include "base/logging.h"
#include "base/threading/thread_local.h"
#include "ui/gl/gl_context.h"
-#include "ui/gl/gl_implementation.h"
namespace gfx {
@@ -55,10 +54,13 @@ bool GLSurface::InitializeOneOff() {
}
}
- initialized = InitializeGLBindings(impl) && InitializeOneOffInternal();
+ initialized = InitializePreBindingsInternal(impl);
no sievers 2014/01/14 23:16:01 Adding InitializePreBindingsInternal() everywhere
oetuaho-nv 2014/01/15 15:50:25 I agree, done.
+ if (initialized)
+ initialized = InitializeStaticGLBindings(impl) &&
+ InitializeOneOffInternal();
if (!initialized && fallback_to_osmesa) {
ClearGLBindings();
- initialized = InitializeGLBindings(kGLImplementationOSMesaGL) &&
+ initialized = InitializeStaticGLBindings(kGLImplementationOSMesaGL) &&
InitializeOneOffInternal();
}

Powered by Google App Engine
This is Rietveld 408576698