Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: ui/gl/gl_context_nsview.mm

Issue 98643013: Take GL version and extensions correctly into account when binding functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Clarify code in generate_bindings.py according to feedback Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_context_nsview.mm
diff --git a/ui/gl/gl_context_nsview.mm b/ui/gl/gl_context_nsview.mm
index dd7a5a64851e4dbea0c833f1e10bc8a45a8b445e..8f38d08166d0a1fa8b08b08e9367456362f588cf 100644
--- a/ui/gl/gl_context_nsview.mm
+++ b/ui/gl/gl_context_nsview.mm
@@ -66,6 +66,10 @@ bool GLContextNSView::MakeCurrent(GLSurface* surface) {
SetRealGLApi();
SetCurrent(surface);
+ if (!InitializeDynamicBindings()) {
+ ReleaseCurrent(surface);
+ return false;
+ }
if (!surface->OnMakeCurrent(this)) {
LOG(ERROR) << "Unable to make gl context current.";

Powered by Google App Engine
This is Rietveld 408576698