Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: ui/gl/gl_bindings.h

Issue 98643013: Take GL version and extensions correctly into account when binding functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Clarify code in generate_bindings.py according to feedback Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_bindings.h
diff --git a/ui/gl/gl_bindings.h b/ui/gl/gl_bindings.h
index abde8c85ff82628d9150c3deed11878df8919c71..fd24c428ece66686cbeae9528c72952a37653055 100644
--- a/ui/gl/gl_bindings.h
+++ b/ui/gl/gl_bindings.h
@@ -225,12 +225,11 @@ typedef uint64 EGLuint64CHROMIUM;
namespace gfx {
struct GL_EXPORT DriverGL {
- void Initialize();
- void InitializeExtensions(GLContext* context);
+ void InitializeStaticBindings();
+ void InitializeCustomDynamicBindings(GLContext* context);
void InitializeDebugBindings();
void InitializeNullDrawBindings();
void ClearBindings();
- void UpdateDebugExtensionBindings();
ProcsGL fn;
ProcsGL orig_fn;
@@ -238,16 +237,14 @@ struct GL_EXPORT DriverGL {
ExtensionsGL ext;
private:
- void InitializeBindings();
- void InitializeExtensionBindings(GLContext* context);
+ void InitializeDynamicBindings(GLContext* context);
};
struct GL_EXPORT DriverOSMESA {
- void InitializeBindings();
- void InitializeExtensionBindings(GLContext* context);
+ void InitializeStaticBindings();
+ void InitializeDynamicBindings(GLContext* context);
void InitializeDebugBindings();
void ClearBindings();
- void UpdateDebugExtensionBindings();
ProcsOSMESA fn;
ProcsOSMESA debug_fn;
@@ -256,11 +253,10 @@ struct GL_EXPORT DriverOSMESA {
#if defined(OS_WIN)
struct GL_EXPORT DriverWGL {
- void InitializeBindings();
- void InitializeExtensionBindings(GLContext* context);
+ void InitializeStaticBindings();
+ void InitializeDynamicBindings(GLContext* context);
void InitializeDebugBindings();
void ClearBindings();
- void UpdateDebugExtensionBindings();
ProcsWGL fn;
ProcsWGL debug_fn;
@@ -270,11 +266,10 @@ struct GL_EXPORT DriverWGL {
#if defined(OS_WIN) || defined(USE_X11) || defined(OS_ANDROID) || defined(USE_OZONE)
struct GL_EXPORT DriverEGL {
- void InitializeBindings();
- void InitializeExtensionBindings(GLContext* context);
+ void InitializeStaticBindings();
+ void InitializeDynamicBindings(GLContext* context);
void InitializeDebugBindings();
void ClearBindings();
- void UpdateDebugExtensionBindings();
ProcsEGL fn;
ProcsEGL debug_fn;
@@ -284,11 +279,10 @@ struct GL_EXPORT DriverEGL {
#if defined(USE_X11)
struct GL_EXPORT DriverGLX {
- void InitializeBindings();
- void InitializeExtensionBindings(GLContext* context);
+ void InitializeStaticBindings();
+ void InitializeDynamicBindings(GLContext* context);
void InitializeDebugBindings();
void ClearBindings();
- void UpdateDebugExtensionBindings();
ProcsGLX fn;
ProcsGLX debug_fn;

Powered by Google App Engine
This is Rietveld 408576698