gpu/tools/compositor_model_bench/compositor_model_bench.cc - Issue 98643013: Take GL version and extensions correctly into account when binding functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/tools/compositor_model_bench/compositor_model_bench.cc

Issue 98643013: Take GL version and extensions correctly into account when binding functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Clarify code in generate_bindings.py according to feedback Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/tools/compositor_model_bench/compositor_model_bench.cc

diff --git a/gpu/tools/compositor_model_bench/compositor_model_bench.cc b/gpu/tools/compositor_model_bench/compositor_model_bench.cc

index 3d7884449a7798b09071def725154d0a9d783f12..44ce333bf679d65ef75c686b78956d2e670ab6e4 100644

--- a/gpu/tools/compositor_model_bench/compositor_model_bench.cc

+++ b/gpu/tools/compositor_model_bench/compositor_model_bench.cc

@@ -186,8 +186,8 @@ class Simulator {

// Initialize the OpenGL context.

bool InitGLContext() {

- if (!InitializeGLBindings(gfx::kGLImplementationDesktopGL)) {

- LOG(FATAL) << "InitializeGLBindings failed";

+ if (!InitializeStaticGLBindings(gfx::kGLImplementationDesktopGL)) {

+ LOG(FATAL) << "InitializeStaticGLBindings failed";

return false;

}

« no previous file with comments | « gpu/config/gpu_info_collector_unittest.cc ('k') | media/tools/player_x11/gl_video_renderer.cc » ('j') | ui/gl/generate_bindings.py » ('J')